-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement classification v2.0.0 #1359
Conversation
2da0e3d
to
e299e79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
- Coverage 91.22% 91.07% -0.15%
==========================================
Files 51 51
Lines 7042 7070 +28
Branches 1008 1012 +4
==========================================
+ Hits 6424 6439 +15
- Misses 443 451 +8
- Partials 175 180 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly concerned about the change in arg order, but otherwise looks good!
Co-authored-by: Julia Signell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for absorbing the nits
You betcha, thanks for the careful checks! |
due to incompatibility with classification extension version 2.0.0 stac-utils/pystac#1359
Related Issue(s):
Description:
nodata
,percentage
, andcount
fieldsdescription
optionalname
requiredPR Checklist:
pre-commit
hooks pass locallyscripts/test
)