Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement classification v2.0.0 #1359

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 1, 2024

Related Issue(s):

Description:

  • Adds the new nodata, percentage, and count fields
  • Makes description optional
  • Make name required
  • Removes a copy-pasta double-check of the color hint

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added the extension Implement a STAC extension in PySTAC label Jul 1, 2024
@gadomski gadomski requested a review from jsignell July 1, 2024 22:20
@gadomski gadomski self-assigned this Jul 1, 2024
@gadomski gadomski force-pushed the issues/1354-update-classification-extension branch from 2da0e3d to e299e79 Compare July 1, 2024 22:21
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.07%. Comparing base (a2a8e5b) to head (c548f90).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
pystac/extensions/classification.py 69.76% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   91.22%   91.07%   -0.15%     
==========================================
  Files          51       51              
  Lines        7042     7070      +28     
  Branches     1008     1012       +4     
==========================================
+ Hits         6424     6439      +15     
- Misses        443      451       +8     
- Partials      175      180       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly concerned about the change in arg order, but otherwise looks good!

pystac/extensions/classification.py Outdated Show resolved Hide resolved
pystac/extensions/classification.py Show resolved Hide resolved
pystac/extensions/classification.py Show resolved Hide resolved
pystac/extensions/classification.py Show resolved Hide resolved
pystac/extensions/classification.py Outdated Show resolved Hide resolved
@gadomski gadomski requested a review from jsignell July 12, 2024 12:24
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for absorbing the nits

@gadomski
Copy link
Member Author

thanks for absorbing the nits

You betcha, thanks for the careful checks!

@gadomski gadomski added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 346ff74 Jul 15, 2024
24 checks passed
@gadomski gadomski deleted the issues/1354-update-classification-extension branch July 15, 2024 17:30
johntruckenbrodt added a commit to SAR-ARD/s1ard that referenced this pull request Oct 21, 2024
due to incompatibility with classification extension version 2.0.0
stac-utils/pystac#1359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Implement a STAC extension in PySTAC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Classification extension to support v2.0.0 spec
2 participants