Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: udpated version #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: udpated version #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fe5752
chore: udpated version
caiorezendezup Jul 17, 2024
0a69423
chore: lint error
caiorezendezup Jul 17, 2024
7001381
chore: version upgrade
caiorezendezup Jul 17, 2024
874224a
chore: remove unused commands for eslint and global
caiorezendezup Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/client/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
declare namespace VScodeAsyncWebviewClient {
interface Window {
original?: {
log: (text: string) => void,
error: (text: string) => void,
},
}
interface Window {
original?: {
log: (text: string) => void,
error: (text: string) => void,
},
}
11 changes: 0 additions & 11 deletions packages/client/src/VSCodeWeb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@ import {
} from '@stack-spot/vscode-async-webview-shared'
import { LinkedBridge, VSCodeWebInterface } from './VSCodeWebInterface'

declare global {
interface Window {
original?: {
log: (text: string) => void,
error: (text: string) => void,
},
}
}

interface StreamingHandler {
onData: (data: string) => void,
onError?: (error: string) => void,
Expand Down Expand Up @@ -80,12 +71,10 @@ export class VSCodeWeb<Bridge extends AsyncStateful = AsyncStateful> implements
}

log(text: string): void {
// eslint-disable-next-line no-console
window.original?.log(text)
}

error(text: string): void {
// eslint-disable-next-line no-console
window.original?.error(text)
}

Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/VSCodeWebInterface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,5 @@ export interface VSCodeWebInterface<
*
* @param {string} text - The error message to log.
*/
error(text: string): void
error(text: string): void,
}
4 changes: 2 additions & 2 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@stack-spot/vscode-async-webview-react",
"version": "0.8.1",
"version": "0.8.2",
"repository": "github:stack-spot/vscode-async-webview",
"main": "out/index.js",
"module": "out/index.mjs",
Expand All @@ -12,7 +12,7 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-scripts": "5.0.1",
"@stack-spot/vscode-async-webview-client": ">=0.7.2"
"@stack-spot/vscode-async-webview-client": ">=0.7.4"
},
"devDependencies": {
"@testing-library/jest-dom": "^5.16.5",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.