Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NiFi 1.15 #125

Merged
merged 13 commits into from
Dec 3, 2021
Merged

Add support for NiFi 1.15 #125

merged 13 commits into from
Dec 3, 2021

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 1, 2021 •
edited
Loading

Description

  • Support for 1.15.0 was added and support for 1.13.2 removed.
  • The now required property nifi.sensitve.props.key can now be set via a secret.
  • The property is mounted as an enviroment variable into the container, it is added to the `nifi.properties by a script. For this to work, the docker image had to be modified, please se related pull request in that repository: Added update_config script to nifi (For NiFi 1.15) docker-images#27
  • A few new config settings were added and old ones removed.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

maltesander
maltesander requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustfmt is complaining. Otherwise i would say we remove 1.13.2 completly?
Edit: Didnt see its still draft:)

rust/crd/src/lib.rs Show resolved Hide resolved
@fhennig fhennig mentioned this pull request Dec 2, 2021
Merged
@fhennig fhennig marked this pull request as ready for review December 3, 2021 11:28
maltesander
maltesander requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

CHANGELOG.md Outdated Show resolved Hide resolved
rust/operator/src/config.rs Outdated Show resolved Hide resolved
rust/operator/src/config.rs Outdated Show resolved Hide resolved
rust/operator/src/lib.rs Outdated Show resolved Hide resolved
maltesander
maltesander requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog link missing

CHANGELOG.md Show resolved Hide resolved
maltesander
maltesander approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig fhennig merged commit 76728c7 into main Dec 3, 2021
@fhennig fhennig deleted the support-15 branch December 3, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @maltesander