Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Emit errors as K8s events #218

Closed
wants to merge 3 commits into from

Conversation

maltesander
Copy link
Member

Description

fixes #177

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 18, 2022 12:51
@maltesander maltesander self-assigned this Feb 18, 2022
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 18, 2022
## Description

fixes #177



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 18, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Emit errors as K8s events [Merged by Bors] - Emit errors as K8s events Feb 18, 2022
@bors bors bot closed this Feb 18, 2022
@bors bors bot deleted the feature/error-events branch February 18, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Kubernetes Events for errors during reconciliation
2 participants