Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support specifying a namespace to watch #223

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Support specifying a namespace to watch #223

wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 24, 2022 •
edited by razvan
Loading

Description

try

cargo run -- run --watch-namespace test

or

export WATCH_NAMESPACE=test
cargo run -- run

fixes #214

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 24, 2022 13:18
@maltesander maltesander marked this pull request as ready for review February 24, 2022 13:46
nightkr
nightkr reviewed Feb 24, 2022
View reviewed changes
docs/modules/ROOT/pages/env_var_args.adoc
@@ -0,0 +1,56 @@

=== PRODUCT_CONFIG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same bunch of fields that we specify in commandline_args.adoc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

Copy link
Member

@nightkr nightkr Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge them into one file then. It's not really obvious that we have two places that need to be kept up to date atm, or how they relate to each other.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean they come together via clap, the new opa side container e.g. does not use clap and would only require the env variable? I think in that case it makes sense to separate it?

docs/modules/ROOT/pages/env_var_args.adoc Outdated Show resolved Hide resolved
razvan
razvan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@maltesander @razvan
Support specifying a namespace to watch (#223)
9b68a18 
## Description

try
```
cargo run -- run --watch-namespace test
```
or
```
export WATCH_NAMESPACE=test
cargo run -- run
```

fixes #214



Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Razvan-Daniel Mihai <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying a namespace to watch [Merged by Bors] - Support specifying a namespace to watch Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the feature/watch_single_namespace branch February 28, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support specifying a namespace to watch
3 participants
@maltesander @razvan @nightkr