Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Adapted versions to 1.18.0 #360

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Adapted versions to 1.18.0 #360

wants to merge 2 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 11, 2022 •
edited
Loading

Description

fixes #358

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Oct 11, 2022
@maltesander maltesander requested a review from a team October 11, 2022 10:07
@maltesander maltesander marked this pull request as ready for review October 11, 2022 10:07
soenkeliebau
soenkeliebau approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - ran tests and those worked flawlessly as well

@maltesander
Copy link
Member Author

bors merge

@maltesander
Copy link
Member Author

lgtm - ran tests and those worked flawlessly as well

almost suspicious :D

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@maltesander
Adapted versions to 1.18.0 (#360)
23cce81 
# Description

fixes #358



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2022

Build failed:

@maltesander
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@maltesander
Adapted versions to 1.18.0 (#360)
6e56247 
# Description

fixes #358



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Adapted versions to 1.18.0 [Merged by Bors] - Adapted versions to 1.18.0 Oct 11, 2022
@bors bors bot closed this Oct 11, 2022
@bors bors bot deleted the support-1.18.0 branch October 11, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW VERSION] 1.18.0
2 participants
@maltesander @soenkeliebau