Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Consolidate global config and fragmented NiFi config #417

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Consolidate global config and fragmented NiFi config #417

wants to merge 9 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jan 25, 2023 •
edited by siegfriedweber
Loading

Description

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Jan 25, 2023
@maltesander maltesander added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels Jan 25, 2023
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/21/

@maltesander maltesander marked this pull request as ready for review January 25, 2023 16:32
siegfriedweber
siegfriedweber requested changes Jan 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
siegfriedweber
siegfriedweber approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@maltesander
Consolidate global config and fragmented NiFi config (#417)
7a54c4b 
# Description

- This is a pre PR for #415
- renamed global `config` to `clusterConfig`
- moved `zookeeper_configmap_name` to `clusterConfig`
- adapted tests, docs and examples



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Consolidate global config and fragmented NiFi config [Merged by Bors] - Consolidate global config and fragmented NiFi config Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@bors bors bot deleted the consolidate-and-fragment-config branch January 26, 2023 12:43
@maltesander maltesander mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @siegfriedweber