Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graceful shutdown #528

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Support graceful shutdown #528

merged 11 commits into from
Nov 16, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Nov 8, 2023 •
edited by sbernauer
Loading

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@maltesander maltesander requested a review from a team November 8, 2023 11:39
@maltesander maltesander self-assigned this Nov 8, 2023
@maltesander maltesander mentioned this pull request Nov 8, 2023
Closed
sbernauer
sbernauer requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
Techassi
Techassi requested changes Nov 9, 2023
View reviewed changes
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
adwk67
adwk67 requested changes Nov 16, 2023
View reviewed changes
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
Techassi
Techassi requested changes Nov 16, 2023
View reviewed changes
rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/operations/graceful_shutdown.rs Outdated Show resolved Hide resolved
sbernauer
sbernauer approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@maltesander maltesander added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 65293b6 Nov 16, 2023
30 checks passed
@maltesander maltesander deleted the feat/graceful-shutdown branch November 16, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@Techassi Techassi Techassi approved these changes

@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maltesander @adwk67 @Techassi @sbernauer