-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow configuring NiFi proxy host behaviour #668
Conversation
Could we add a test for this (e.g. set a proxy header in the smoke test and check if its set in the pod / configmap / settings- see https://github.com/stackabletech/trino-operator/blob/main/tests/templates/kuttl/resources/20-assert.yaml)? |
I've added an extra TestAssert step to the smoke test to not spam the test logs during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I would say (and with regard to the many support cases) to add a small documentation entry (explaining the whole *
allow all behavior since this is patched by us and ready to be picked up by SEO)?
Edit: Changelog missing!
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks, LGTM!
Description
Allow adding proxy hosts that should be allowed by NiFi or turning the host header check off entirely.
Definition of Done Checklist
Author
Reviewer
Acceptance