Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring NiFi proxy host behaviour #668

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Aug 22, 2024

Description

Allow adding proxy hosts that should be allowed by NiFi or turning the host header check off entirely.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@labrenbe labrenbe linked an issue Aug 22, 2024 that may be closed by this pull request
@labrenbe labrenbe marked this pull request as ready for review August 26, 2024 09:53
@maltesander
Copy link
Member

Could we add a test for this (e.g. set a proxy header in the smoke test and check if its set in the pod / configmap / settings- see https://github.com/stackabletech/trino-operator/blob/main/tests/templates/kuttl/resources/20-assert.yaml)?

@labrenbe
Copy link
Member Author

labrenbe commented Aug 26, 2024

Could we add a test for this (e.g. set a proxy header in the smoke test and check if its set in the pod / configmap / settings- see https://github.com/stackabletech/trino-operator/blob/main/tests/templates/kuttl/resources/20-assert.yaml)?

I've added an extra TestAssert step to the smoke test to not spam the test logs during 30-assert.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I would say (and with regard to the many support cases) to add a small documentation entry (explaining the whole * allow all behavior since this is patched by us and ready to be picked up by SEO)?
Edit: Changelog missing!

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, LGTM!

@labrenbe labrenbe added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 253c34d Aug 28, 2024
31 checks passed
@labrenbe labrenbe deleted the feat/allowed-proxy-host-configuration branch August 28, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring NiFi proxy host behaviour
2 participants