Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Change PodBuilder::termination_grace_period to take Duration struct #672

Merged
merged 8 commits into from
Oct 13, 2023
Merged

refactor!: Change PodBuilder::termination_grace_period to take Duration struct #672

merged 8 commits into from
Oct 13, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 12, 2023 •
edited
Loading

Description

Part of stackabletech/issues#357

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@sbernauer sbernauer changed the title reafctor!: Change PodBuilder::termination_grace_period to take Duration struct refactor!: Change PodBuilder::termination_grace_period to take Duration struct Oct 12, 2023
@sbernauer sbernauer mentioned this pull request Oct 12, 2023
Merged
@sbernauer sbernauer mentioned this pull request Oct 12, 2023
Closed
@sbernauer sbernauer self-assigned this Oct 12, 2023
Techassi
Techassi reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I added a small comment about the upstream change. This can be approved when the upstream decision is made.

src/builder/pod/mod.rs Outdated Show resolved Hide resolved
nightkr
nightkr reviewed Oct 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
nightkr
nightkr reviewed Oct 12, 2023
View reviewed changes
src/builder/pod/mod.rs Outdated Show resolved Hide resolved
src/builder/pod/mod.rs Outdated Show resolved Hide resolved
src/builder/pod/mod.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit ba1b2e2 Oct 13, 2023
17 checks passed
@sbernauer sbernauer deleted the refactor/pod-graceful-duration branch October 13, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@nightkr nightkr nightkr approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @nightkr @Techassi