Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make PURLs use oci type / include architecture in --source-version #448

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Oct 16, 2024

Same thing as stackabletech/actions#11, but for our operator images. It probably makes sense for the same person to review both this PR and the other.


Use OCI type for PURLs, according to https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#oci

This is more correct in general and most importantly makes the PURL equal to the one Trivy generates for our container images.

Hint: To check the PURL Trivy generates, run for example these commands:

trivy image --scanners vuln -f cyclonedx -o airflow-result.cdx.json oci.stackable.tech/sdp/airflow-operator:0.0.0-dev-amd64
jq -r '.metadata.component.purl' airflow-result.cdx.json

The second commit includes the architecture in the component version in the SBOM (0.0.0-dev-amd64 instead of 0.0.0-dev). That is in line with the image tag and we also do it this way with our product images.

@dervoeti dervoeti changed the title fix: make PURLs use oci type fix: make PURLs use oci type / include architecture in --source-version Oct 18, 2024
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KGTM, but it I would highly recommend that we adjust the workflow to use our central actions instead of relying on these custom Makefile commands.

This can be tackled after the release of SDP 24.11 is done.

@dervoeti dervoeti added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 8068f34 Oct 21, 2024
2 checks passed
@dervoeti dervoeti deleted the fix/oci-purls branch October 21, 2024 06:54
@dervoeti dervoeti self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants