Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly pick up SBOMs inside the container / specify CycloneDX version #461

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Nov 13, 2024

Problem: SBOMs for our operator images do not contain cargo dependencies at the moment
We generate SBOMs for the Rust binaries at build time and Syft should pick them up to include the components in the SBOM for the container. This is done by the "SBOM cataloger" in Syft. Syft disabled the SBOM cataloger to run by default with this PR (released with Syft v0.102.0). The Syft version regularly gets bumped by stackable-bot (example), which indirectly disabled picking up the generated SBOMs in the container by bumping the Syft version.

This PR has two changes:

  1. Pin CycloneDX version to 1.5 (was using the latest version by default, we can think about using 1.6 at some point, I haven't looked at the changes yet, just checked 1.5 when I implemented SBOM generation)
  2. Explicitly enable sbom-cataloger

This also makes the Syft command exactly the same as in our product images.

@dervoeti dervoeti added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit b4b8ee1 Nov 13, 2024
2 checks passed
@dervoeti dervoeti deleted the fix/sbom-generation branch November 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants