Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support graceful shutdown #740

Merged
merged 7 commits into from
Nov 6, 2023
Merged

feat: Support graceful shutdown #740

merged 7 commits into from
Nov 6, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 3, 2023

Description

Part of stackabletech/issues#357

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@sbernauer
Copy link
Member Author

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, LGTM otherwise!

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit c930bd2 Nov 6, 2023
30 checks passed
@sbernauer sbernauer deleted the feat/graceful-shutdown branch November 6, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants