Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Add Node.js v22 and use runner.os #294

Merged
merged 3 commits into from
Oct 6, 2024
Merged

GitHub Actions: Add Node.js v22 and use runner.os #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e9b8c2
GitHub Actions" Add Node.js v22 and use runner.os
cclauss Aug 29, 2024
3174bfb
package.json: dependencies "node-gyp": "^10.2.0",
cclauss Aug 29, 2024
7310904
Update ci.yml
cclauss Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
os: [ubuntu-latest, windows-latest, macos-latest]
steps:
- uses: actions/checkout@v4
Expand All @@ -21,13 +21,14 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- if: startsWith(matrix.os, 'ubuntu')
- if: runner.os == 'Linux'
run: sudo apt-get install -y build-essential libgl1-mesa-dri libglapi-mesa
libglew-dev libglu1-mesa-dev libosmesa6
libxi-dev mesa-utils pkg-config
- run: npm ci
- run: rm package-lock.json
- run: npm install
Copy link
Author

@cclauss cclauss Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once package.json and package-lock.json have been upgraded to node-gyp==^10.2.0 then these two lines should be reverted back to - run: npm ci to align with AppVeyor.

- run: npm run build --if-present
- if: startsWith(matrix.os, 'ubuntu')
- if: runner.os == 'Linux'
run: xvfb-run npm test
- if: "!startsWith(matrix.os, 'ubuntu')"
- if: runner.os != 'Linux'
run: npm test
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"glsl-tokenizer": "^2.1.5",
"nan": "^2.18.0",
"node-abi": "^3.56.0",
"node-gyp": "^10.0.1",
"node-gyp": "^10.2.0",
"prebuild-install": "^7.1.1"
},
"devDependencies": {
Expand Down