-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install fork of ansible with Rocky 8 support #60
Conversation
This means we would support Rocky 8 out of the box. Otherwise, we need to install the ansible fork as another step. I'm trying to avoid this in the stackhpc AIO scenario to keep it simple.
@@ -1,5 +1,6 @@ | |||
pbr>=2.0 # Apache-2.0 | |||
ansible>=2.9.0,<2.11.0,!=2.9.8,!=2.9.12 # GPLv3 | |||
ansible-base@git+https://github.com/stackhpc/ansible@stackhpc/2.10/rocky # GPLv3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could use an environment marker to apply this only to Rocky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea. I guess that would work if you matched the OS on your control host with the hosts targeted by ansible, but if for instance you tried to use a ubuntu control host to configure a Rocky host, wouldn't you end up install a version of ansible without Rocky support.
Or were you thinking more an environment variable that would switch the behaviour? I think in the AIO one jobs we share the same kayobe docker image, so we might end up using this version of ansible for all jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I suppose you're right there.
My hesitation was in using a stale version of ansible, but actually it's EOL, and you have the final commit in that branch.
@@ -1,5 +1,6 @@ | |||
pbr>=2.0 # Apache-2.0 | |||
ansible>=2.9.0,<2.11.0,!=2.9.8,!=2.9.12 # GPLv3 | |||
ansible-base@git+https://github.com/stackhpc/ansible@stackhpc/2.10/rocky # GPLv3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I suppose you're right there.
My hesitation was in using a stale version of ansible, but actually it's EOL, and you have the final commit in that branch.
This means we would support Rocky 8 out of the box. Otherwise, we need to install the ansible fork as another step. I'm trying to avoid this in the stackhpc AIO scenario to keep it simple.