[ironic] add coordination backend for ironic inspector #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ide82b7a7fa6752b60f2c9c31cdc4c79183fc62f6 (cherry picked from commit 2edc32f)
markgoddard
reviewed
Aug 30, 2022
|
I am aware of this fix: I wanted to test the coordination backend on sms-lab. |
markgoddard
reviewed
Aug 30, 2022
| @@ -1214,6 +1214,9 @@ ironic_admin_endpoint: "{{ admin_protocol }}://{{ ironic_internal_fqdn | put_add | |||
| ironic_internal_endpoint: "{{ internal_protocol }}://{{ ironic_internal_fqdn | put_address_in_context('url') }}:{{ ironic_api_port }}" | |||
| ironic_public_endpoint: "{{ public_protocol }}://{{ ironic_external_fqdn | put_address_in_context('url') }}:{{ ironic_api_port }}" | |||
|
|
|||
| # Valid options are [ '', redis, etcd ] | |||
| ironic_coordination_backend: "{{ 'redis' if enable_redis|bool else 'etcd' if enable_etcd|bool else '' }}" | |||
There was a problem hiding this comment.
Is there any risk in backporting this? Existing systems with redis or etcd deployed will start to use coordination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ide82b7a7fa6752b60f2c9c31cdc4c79183fc62f6
(cherry picked from commit 2edc32f)