Skip to content

Commit

Permalink
Merge "Unpin td-agent and cap elasticsearch gem" into stable/xena
Browse files Browse the repository at this point in the history
  • Loading branch information
Zuul authored and openstack-gerrit committed Feb 16, 2022
2 parents 47aac3c + 5c6eb17 commit 7efe0cc
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
5 changes: 0 additions & 5 deletions docker/base/apt_preferences.debian
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ Package: erlang*
Pin: version 1:23.*
Pin-Priority: 1000

# FIXME(mgoddard): Pinning to 4.0.* to avoid bug 1930867.
Package: td-agent*
Pin: version 4.0.*
Pin-Priority: 1000

# NOTE(mgoddard): logstash 7.9.x is the last version that supports
# Elasticsearch OSS.
Package: logstash-oss
Expand Down
5 changes: 0 additions & 5 deletions docker/base/apt_preferences.ubuntu
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ Package: erlang*
Pin: version 1:23.*
Pin-Priority: 1000

# FIXME(mgoddard): Pinning to 4.0.* to avoid bug 1930867.
Package: td-agent*
Pin: version 4.0.*
Pin-Priority: 1000

# NOTE(mgoddard): logstash 7.9.x is the last version that supports
# Elasticsearch OSS.
Package: logstash-oss
Expand Down
12 changes: 9 additions & 3 deletions docker/fluentd/Dockerfile.j2
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ LABEL fluentd_version="0.14" fluentd_binary="td-agent"
] %}

{% if base_arch in ['aarch64', 'x86_64'] %}
# FIXME(mgoddard): Pinning to 4.0.* to avoid bug 1930867.
{% set fluentd_packages = fluentd_packages + [
'td-agent-4.0.*'
'td-agent'
] %}
{% else %}
{% set fluentd_packages = fluentd_packages + [
Expand Down Expand Up @@ -62,7 +61,14 @@ LABEL fluentd_version="0.14" fluentd_binary="td-agent"
{% endif %}

{{ macros.configure_user(name=fluentd_user, groups='mysql') }}
{{ macros.install_packages(fluentd_packages | customizable("packages")) }}

# NOTE(frickler): Downgrading elasticsearch gems for compatibility with OSS versions of ES
{{ macros.install_packages(fluentd_packages | customizable("packages")) }}{% if base_arch in ['aarch64', 'x86_64'] %} \
&& td-agent-gem install elasticsearch:7.13.0 \
&& td-agent-gem uninstall "elasticsearch:>7.13.0" \
&& td-agent-gem uninstall "elasticsearch-api:>7.13.0" \
&& td-agent-gem uninstall "elasticsearch-transport:>7.13.0"
{% endif %}

# Distro specific files and operations
# Fluentd on rpm-based non-x86_64 is installed from rpm
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
Latest version of the elasticsearch gem no longer works with older
(OSS) versions of Elasticsearch. This is fixed by capping the version
of the elasticsearch gem installed into the fluentd container.
`LP#1954759 <https://launchpad.net/bugs/1954759>`__

0 comments on commit 7efe0cc

Please sign in to comment.