Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported variables from overcloud-dib.yml #95

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

markgoddard
Copy link

These came in with the Rocky Linux backport, but without the accompanying support in Kayobe.

These came in with the Rocky Linux backport, but without the accompanying support in Kayobe.
@markgoddard markgoddard self-assigned this Jul 22, 2022
@markgoddard markgoddard merged commit 3693e07 into stackhpc/wallaby Jul 26, 2022
@markgoddard markgoddard deleted the wallaby-fix-overcloud-dib branch July 26, 2022 12:22
@priteau
Copy link
Member

priteau commented Jul 26, 2022

Wouldn't it be better to backport the associated commit?

@markgoddard
Copy link
Author

Wouldn't it be better to backport the associated commit?

It's not necessary for rocky linux afaik, the config came in by mistake via a merge conflict.

@priteau
Copy link
Member

priteau commented Jul 26, 2022

I didn't mean for Rocky specifically, but rather if we want to build multiple images or if we want to use custom elements stored in Git.

@markgoddard
Copy link
Author

I didn't mean for Rocky specifically, but rather if we want to build multiple images or if we want to use custom elements stored in Git.

I don't mind either way. If someone wants to backport, I'll approve.

@markgoddard
Copy link
Author

I didn't mean for Rocky specifically, but rather if we want to build multiple images or if we want to use custom elements stored in Git.

I don't mind either way. If someone wants to backport, I'll approve.

Seems I might need the git support today...

@priteau
Copy link
Member

priteau commented Jul 27, 2022

stackhpc/kayobe#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants