Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monolog V3 Support #23

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Monolog V3 Support #23

merged 6 commits into from
Dec 20, 2023

Conversation

homiedopie
Copy link
Contributor

@homiedopie homiedopie commented Nov 27, 2023 •
edited
Loading

This is to support only Monolog V3

  • This will require an update to the stackify/logger to support psr/log 2.0 | 3.0

@t-lair
Copy link
Contributor

t-lair commented Dec 19, 2023

@homiedopie we have branches for 1.x and 2.x, so should we make a 3.x for this too?

@t-lair t-lair assigned t-lair and unassigned t-lair Dec 19, 2023
@t-lair t-lair self-requested a review December 19, 2023 21:08
@homiedopie
Copy link
Contributor Author

@t-lair - Yup we should. Just to make it consistent with the v2 version

@homiedopie homiedopie changed the base branch from master to feature/monolog-v3-support December 20, 2023 15:02
@homiedopie
Copy link
Contributor Author

Changing base to a new branch for pipeline testing @t-lair . Requesting for merge thanks!

@t-lair t-lair self-requested a review December 20, 2023 16:40
@homiedopie homiedopie merged commit 0b17632 into stackify:feature/monolog-v3-support Dec 20, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-lair t-lair t-lair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@homiedopie @t-lair