Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix project name param for run command #38

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

johnsca
Copy link
Contributor

@johnsca johnsca commented Oct 4, 2023

The change in #37 (specifically, this line) means that the SinistralFormat class attribute will never be set, so we should use the local var instead.

The change in #37 means that the SinistralFormat class attribute will
never set, so we should use the local var instead.
Copy link
Contributor

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@johnsca johnsca merged commit b59fbd1 into main Oct 4, 2023
4 checks passed
@johnsca johnsca deleted the johnsca/fix/run-command-project-name branch October 4, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants