Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectOverview merge is too approximate #47

Open
rimutaka opened this issue Dec 18, 2021 · 0 comments
Open

ProjectOverview merge is too approximate #47

rimutaka opened this issue Dec 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@rimutaka
Copy link
Member

A dev may make commits to the same project under different identities. STM produces individual reports for every contributor and then merges them. It result in the same files being counted multiple time during the merge.

The problem came to head when multiple ProjectOverview records started appearing for the same project in dev profiles.

I added a merge to make sure the same project is not listed twice in the profile by merging multiple ProjectOverview records. By that time a lot of useful info is lost and it is impossible to tell if the numbers from the overviews should be added, swapped or left intact. There is just not enough info.

Solution

  1. Build a combined list of objects for all git identities
  2. Process the object
  3. Produce a combined contributor report without a need for merging
  • This will not help the data from GH because the code does not know who is who at the time of processing the repo. It should pull the list of git identities from the DB first.
@rimutaka rimutaka added the bug Something isn't working label Dec 18, 2021
rimutaka added a commit that referenced this issue Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant