Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

isUserSignedIn caches the userSession from shared preferences #116

Open
friedger opened this issue Dec 1, 2018 · 1 comment
Open

isUserSignedIn caches the userSession from shared preferences #116

friedger opened this issue Dec 1, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@friedger
Copy link
Collaborator

friedger commented Dec 1, 2018 •
edited
Loading

The default implementation of BlockstackSession uses SessionStore backed by the default shared preferences.

If two BlockstackSession exists backed by the same preferences and the user is logged out in one session then the second does not reflect that.
@friedger friedger added the bug Something isn't working label Dec 1, 2018
@friedger friedger changed the title isUserSignedIn is never false isUserSignedIn caches the userSession from shared preferences Dec 4, 2018
@friedger
Copy link
Collaborator Author

friedger commented Dec 4, 2018

A workaround is to use a single instance of SessionStore that is used in both BlockstackSessions.

This needs to be documented or the default SessionStore should not cache the state of the preferences.

friedger added a commit that referenced this issue Jan 18, 2019
@friedger
fix #116, add documentation
15d04ae
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@friedger