Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Use md5 hash of app public key to identify a user #82

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

friedger
Copy link
Collaborator

This PR

  • uses the md5 hash of the app public key to identify users instead of usernames.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@hstove
Copy link
Collaborator

hstove commented Apr 1, 2020

Overall, something like this is a good idea. Thanks @talhasch for the submission!

  • Needs tests
  • Won't this break for all existing users? They'll have data stored under their "username" ID

I see the window._reservedUsernames thing, but there doesn't seem to be any place where that variable is set. I would assume it's there to not be a breaking change, but it doesn't look fully working yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants