-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify stacks transaction signing #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice stuff! My main consideration is how we represent the public keys in the wallet type, where I think it should be a BTreeMap
of the stacks variant of the public key type in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…ract call transactions
4af714f
to
5de4d6f
Compare
Description
Closes #262. What is left is documentation on what the flow is supposed to look like, which is what #267 is for.
This PR simplifies part of the process of signing stacks transactions. The coordinator can use the code here to generate transactions that other signers can sign and combine the signatures into a final transaction. The final transaction that will (very likely) pass verification on a stacks-core node.
Changes
Testing information
There are unit tests that check that the final signed
StacksTransaction
will pass verification. The integration tests that check validation on a stacks node will be done in #263 and #264.