Fix signer_chainstate test and add it to CI

Signed-off-by: Jacinta Ferrant <[email protected]>
stacks-network · Nov 5, 2024 · 0fbe07f · 0fbe07f
1 parent 67e254e
commit 0fbe07f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/bitcoin-tests.yml b/.github/workflows/bitcoin-tests.yml
@@ -134,6 +134,7 @@ jobs:
           - tests::nakamoto_integrations::utxo_check_on_startup_panic
           - tests::nakamoto_integrations::utxo_check_on_startup_recover
           - tests::nakamoto_integrations::v3_signer_api_endpoint
+          - tests::nakamoto_integrations::signer_chainstate
           # TODO: enable these once v1 signer is supported by a new nakamoto epoch
           # - tests::signer::v1::dkg
           # - tests::signer::v1::sign_request_rejected

diff --git a/stacks-signer/src/chainstate.rs b/stacks-signer/src/chainstate.rs
@@ -482,11 +482,12 @@ impl SortitionsView {
                 if signed_over_time + tenure_last_block_proposal_timeout.as_secs()
                     > get_epoch_time_secs()
                 {
+                    // The last locally accepted block is not timed out, return it
                     return Ok(Some(local_info));
                 }
             }
         }
-
+        // The last locally accepted block is timed out, get the last globally accepted block
         signer_db
             .get_last_globally_accepted_block(consensus_hash)
             .map_err(|e| ClientError::InvalidResponse(e.to_string()))

diff --git a/testnet/stacks-node/src/tests/nakamoto_integrations.rs b/testnet/stacks-node/src/tests/nakamoto_integrations.rs
@@ -6543,10 +6543,10 @@ fn signer_chainstate() {
                 valid: Some(true),
                 signed_over: true,
                 proposed_time: get_epoch_time_secs(),
-                signed_self: None,
-                signed_group: None,
+                signed_self: Some(get_epoch_time_secs()),
+                signed_group: Some(get_epoch_time_secs()),
                 ext: ExtraBlockInfo::None,
-                state: BlockState::Unprocessed,
+                state: BlockState::GloballyAccepted,
             })
             .unwrap();