-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple commits for btc block, missed target block #2969
Comments
Yup, looks like a bug:
The miner should be RBF'ing its in-flight block-commits, or if it can't for some reason, then it should not attempt to mine again. |
Hi, @jcnelson, @diwakergupta |
We're working on it, and PRs are welcome. Looking at these transactions, the node is trying to spend different UTXOs for each attempted block-commit. One remediation you can take is to consolidate your UTXOs into a single UTXO, which would prevent this from happening. |
Does this show up in your logs anywhere?
Some background (cc @lgalabru who wrote this): the miner will make multiple attempts to mine a Stacks block during a Bitcoin block, and will do so even if it can't RBF. This is by design, per the following rules:
You might be hitting case 2(i)(b), in which case, the miner will send multiple block-commits with different UTXOs. The presence of the above log line in your logfile will indicate this. A question for @lgalabru is whether or not this case is one we should support, if it's going to cause problems like this in practice. Perhaps there should be a config option that disables case 2(i)(b) by default? |
no there isn't
i am pretty sure that at the moment of the bug there was no other UTXO sufficient to make a tx |
Issue occurred again, there is only one UTXO in the wallet
you can find full debug log here https://watcher-data.s3.amazonaws.com/multiple_commits_329.log.gz |
… is different than the one used to queue the original tenure. Possibly fixes #2969 as well.
Hey, I may have a fix for this. I'm testing it out right now with the mock miner. The issue appears to be that the node doesn't quite realize that the Bitcoin chain has moved on from the request to attempt to build a block. The |
I've confirmed that this behavior has at least stopped on the Foundation miner with #2989 applied. The root cause was due to the node attempting to process stale sortition requests. Going to go ahead and close this issue; please re-open if it happens again. The fix is available in the current release candidate (2.05.0.1.0-rc4), and will be available in the next release. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Describe the bug
Multiple commits for series of btc blocks detected, missed target block
https://btc.com/btc/transaction/10d26d88f6d2fd18e1b593b74c99886b8da5519ac4b5fd36035043e44ee26345
https://btc.com/btc/transaction/02740d28e351394ce7dac1f7440c59e69d5544ebe3f05f65870f24d7033d3aaf
https://btc.com/btc/transaction/99e7e232c915b120d7d553c92a46f7366d8cd2747db893b53e5c3685d78bcff3
https://btc.com/btc/transaction/7daf7a50fb69abd7c0c3ff2558bc627c9579c246f42c721297680a52184ebd18
https://btc.com/btc/transaction/15643a45ac954a88c11e8d80e76752226fd5dae56ac3698290393a8b67a6f5ff
https://btc.com/btc/transaction/d5dafd4661c4fb3a5bdf8f15f13420193abf6e102b1c657464f7309cceee346b
https://btc.com/btc/transaction/97383a59e877a537d19fbb7b6f4bdc143f98dbf2ab0f0bc47ab4bb09f2cff4ad
https://btc.com/btc/transaction/a264a1508bf1f89bdc2f989d2eb686b968db2b2c7ea07ed023834b35f6a7787b
https://btc.com/btc/transaction/01d6169694017c48b1b6495f91c5b3f3fcd000419812e769f7f26536400dcd6d
https://btc.com/btc/transaction/1ae5682ff9346234c1cb1928999d6b684f393fd24cec826fec4f3b59043d96f9
logs attached, can't provide full debug log
Steps To Reproduce
no info
Expected behavior
one commit per block
Environment (please complete the following information):
Additional context
multiple_commits_main.log
The text was updated successfully, but these errors were encountered: