Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puppet-chain directory and binary #3195

Closed
kantai opened this issue Jul 12, 2022 · 5 comments
Closed

Remove puppet-chain directory and binary #3195

kantai opened this issue Jul 12, 2022 · 5 comments
Labels
chore Necessary but less impactful tasks such as cleanup or reorg good first issue Appropriate for a new open source contribution. locked

Comments

@kantai
Copy link
Member

kantai commented Jul 12, 2022

The puppet-chain binary doesn't seem to be used anymore -- clarinet integrate and devnet do not use it for setting up a local regtest environment, and our integration tests do not use it either.

It could still be useful for developers trying to spin up their own bitcoin regtest environment. However, I feel pretty ambivalent about supporting that use case through the puppet-chain: we don't really cover that use case with our tests, so the current level of support is at best "waiting for an undetected regression", and we're probably better off just eliminating puppet-chain and supporting local regtest through direct bitcoin interaction (that's what our neon_integrations tests do).

@kantai kantai added chore Necessary but less impactful tasks such as cleanup or reorg good first issue Appropriate for a new open source contribution. labels Jul 12, 2022
@kantai
Copy link
Member Author

kantai commented Jul 12, 2022

This came up from a discussion started by @wileyj in the stacks-core-devs discord.

@wileyj
Copy link
Contributor

wileyj commented Jul 12, 2022

adding some more context: puppet-chain is currently used in the "net-test" tests that are disabled in the github action workflow currently: https://github.com/stacks-network/stacks-blockchain/blob/master/.github/workflows/ci.yml#L73-L75

puppet-chain is still built/installed in Dockerfiles, ex: https://github.com/stacks-network/stacks-blockchain/blob/master/Dockerfile#L16-L19

and the net-test test would likely need to be adjusted or removed to account for puppet-chain removal: https://github.com/stacks-network/stacks-blockchain/blob/master/net-test/bin/start.sh#L57-L83

@wileyj
Copy link
Contributor

wileyj commented Jul 12, 2022

As an alternative to removing it, could the source be moved to ./contrib and remove the compilation from build scripts/Dockerfiles as a default?

@jcnelson
Copy link
Member

jcnelson commented Dec 5, 2022

Looks like this happened.

@jcnelson jcnelson closed this as completed Dec 5, 2022
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Necessary but less impactful tasks such as cleanup or reorg good first issue Appropriate for a new open source contribution. locked
Projects
None yet
Development

No branches or pull requests

4 participants