Move puppet-chain to contrib/tools

[wileyj]

• Move puppet-chain src to contrib/tools
• Update base Dockerfiles to not build/copy puppet-chain
• ignore contrib/tools/puppet-chain/target

This PR moves the puppet-chain source to ./contrib/tools directory.
It also removes the build from the main workspace and Dockerfiles where it's mentioned.

What it doesn't do: net-test shell scripts still reference puppet-chain, but since those tests are not active it can be addressed in another issue to update net-test as a whole.

Applicable issues

• fixes Remove puppet-chain directory and binary #3195

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Merging #3200 (b112edc) into develop (69a384f) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3200      +/-   ##
===========================================
+ Coverage    82.57%   82.67%   +0.09%     
===========================================
  Files          261      260       -1     
  Lines       205409   205170     -239     
===========================================
+ Hits        169619   169624       +5     
+ Misses       35790    35546     -244     

Impacted Files	Coverage Δ
testnet/stacks-node/src/tests/epoch_205.rs	74.95% <0.00%> (-23.08%)	⬇️
src/burnchains/bitcoin/network.rs	77.31% <0.00%> (-3.71%)	⬇️
src/chainstate/stacks/index/file.rs	90.12% <0.00%> (-1.28%)	⬇️
src/net/dns.rs	90.25% <0.00%> (-0.86%)	⬇️
testnet/stacks-node/src/keychain.rs	90.06% <0.00%> (-0.63%)	⬇️
src/util_lib/db.rs	81.92% <0.00%> (-0.51%)	⬇️
src/burnchains/bitcoin/spv.rs	73.91% <0.00%> (-0.27%)	⬇️
clarity/src/vm/costs/mod.rs	81.94% <0.00%> (-0.25%)	⬇️
src/util_lib/bloom.rs	92.73% <0.00%> (-0.14%)	⬇️
src/net/chat.rs	82.44% <0.00%> (-0.12%)	⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kantai]

LGTM!

[jcnelson]

Isn't this called stacks-inspect now?

[wileyj]

Not sure - this is isn't something I changed in my branch, but I can update that file in this PR if it needs to be changed.

[jcnelson]

LGTM, but let's make sure the build-publish and build-publish-stretch CI jobs continue to work before merging.

[wileyj]

LGTM, but let's make sure the build-publish and build-publish-stretch CI jobs continue to work before merging.

An excellent point, there are a few things I've just now noticed that shouldn't have been part of this PR so i'll address them first.
Namely, the Dockerfiles are slightly updated with some changes in my other PR (#3199 ) that shouldn't be in this PR.
as-is, merging this would break the current CI (unless that other PR is merged first which is not likely).
i.e. Dockerfile.stretch being renamed to Dockerfile.debian would break the CI

will address and ping back shortly

[wileyj]

LGTM, but let's make sure the build-publish and build-publish-stretch CI jobs continue to work before merging.

8ff40c6

[wileyj]

LGTM, but let's make sure the build-publish and build-publish-stretch CI jobs continue to work before merging.

I've checked over the files in this PR, and I strongly suspect what's causing the failures here are that my fork of the stacks-blockchain repo doesn't have access to the secrets required for the "login to dockerhub" step. as a result, the docker build is skipped since the login step is failing.

Merging this with upstream will resolve, since the secrets there would be correct.

That said, I'm confident this PR is ready to go (tested the dockerfile builds, and both are working as expected - along with running the binaries in both the alpine and stretch images).

Once this is merged with the develop branch, i think all the failed tests that would normally pass will succeed.

[jcnelson]

Alright, going ahead and merging. Please keep an eye on CI -- these steps must pass for develop.

[wileyj]

Alright, going ahead and merging. Please keep an eye on CI -- these steps must pass for develop.

suspicions confirmed: https://github.com/stacks-network/stacks-blockchain/actions/runs/2835581029
all good, thanks!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.