Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacks-signer] Signers should broadcast the same DKG when their broadcasted transaction is no longer valid #4615

Closed
jferrant opened this issue Apr 2, 2024 · 1 comment

Comments

@jferrant
Copy link
Collaborator

jferrant commented Apr 2, 2024

Currently signers only best effort construct a DKG vote-for-aggregate transaction. If the same account builds a vote at the same time as another transaction submission, nonces could be wrong. The signer will not think to broadcast an updated transaction if the nonce is bad and may even trigger an entirely new dkg round. Should not do a new DKG round, but should attempt to rebroadcast their vote if it was never registered in the contract and their nonce is oudated.

@jferrant jferrant self-assigned this Apr 2, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Apr 2, 2024
@jferrant jferrant moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Apr 2, 2024
@jferrant jferrant added the 2.5 label Apr 2, 2024
@jferrant jferrant closed this as completed Apr 4, 2024
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Apr 4, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

2 participants