Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider nonce when checking for existing vote transactions in stacke… #4621

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Apr 2, 2024

This PR addresses the issue that can occur if a signer account is used to generate stacks transactions external to the signer binary operation. This is not normally an issue unless the created transaction occurs in the same block. Signers should attempt to resubmit a vote if it is found to be unconfirmed (i.e. they have not voted yet) and the tx is still sitting in stackerdb transaction slot with an outdated nonce.

Closes #4615

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 83.24%. Comparing base (132ced0) to head (53f2635).
Report is 5 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4621      +/-   ##
==========================================
+ Coverage   77.78%   83.24%   +5.45%     
==========================================
  Files         470      470              
  Lines      332564   332714     +150     
  Branches      317      317              
==========================================
+ Hits       258690   276952   +18262     
+ Misses      73866    55754   -18112     
  Partials        8        8              
Files Coverage Δ
stackslib/src/chainstate/nakamoto/signer_set.rs 82.16% <100.00%> (ø)
stacks-signer/src/signer.rs 72.64% <80.00%> (+0.47%) ⬆️

... and 214 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132ced0...53f2635. Read the comment docs.

Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jferrant jferrant added this pull request to the merge queue Apr 3, 2024
Merged via the queue into next with commit 929a9b8 Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants