Local testnet implementation #1202
Conversation
…net-runloop # Conflicts: # src/chainstate/stacks/db/blocks.rs # src/chainstate/stacks/db/mod.rs
|
The code looks good to me, but before merging, we should have good test coverage. Can you add some unit tests to do something like simulate a few rounds of the testnet with some sample transactions applied, and verify that the transactions all get mined? The tests should also cover mining invalid transactions -- both malformed transactions and transactions that throw runtime exceptions. |
|
Great, on it! thanks! |
Simple signer CLI
src/chainstate/stacks/mod.rs
Outdated
| @@ -42,7 +42,7 @@ use util::hash::HASH160_ENCODED_SIZE; | |||
| use util::strings::StacksString; | |||
| use util::secp256k1::MessageSignature; | |||
|
|
|||
| use address::AddressHashMode; | |||
| pub use address::AddressHashMode; | |||
There was a problem hiding this comment.
Why add this? Why not just import address::AddressHashMode in whatever module(s) that try to import AddressHashMode from here?
There was a problem hiding this comment.
Gotcha. Thanks for taking care of it nevertheless 👍
|
|
||
| assert!(&h_comp != &h_uncomp); | ||
| assert_eq!(h_comp.len(), 66); | ||
| assert_eq!(h_uncomp.len(), 64); |
There was a problem hiding this comment.
Can you also test that the final two characters in h_comp are 01, and that h_comp and h_uncomp are equal up to the 64th byte?
There was a problem hiding this comment.
Ah, gotcha. Thanks for fixing it nevertheless 👍
This PR is addressing #1180
Current status:
Looks functional 🎉.
With this PR, developers now have the ability to run a "testnet" on their machine.
The DX for using the testnet is a bit impractical at this point: developers need to generate signed transactions blobs using the command line (#1203), redirect the output in a file (binary format), and place the file in the mempool folder (set by the config).
The implementation of #1179 should improve the DX.
I think that we should also think about de-frosting https://github.com/blockstack/clarity-js-sdk (cc @zone117x) and start building a comprehensive flow for smart contract developers, that would cover tx signing + submission.
Concerning the implementation, in a nutshell, the testnet and its runloop is being setup with a
Configstruct, setting the average block time, the number of desired nodes, and their config (mempool path, etc).Each node will maintain its chain state. When a node win a sortition, it will start a new
LeaderTenure(also having its own chain state), and will start polling a mempool and building blocks / micro blocks.At
average_block_time / 2, the tenure will terminate, and return some artifacts (anchor-block, micro-blocks) that will be shared with the other nodes, so that they can submit theirCommitBlockOpto the burnchain.Current limitations that should not be blocking and that can be addressed in a separate PR (if that's ok with the team):
LeaderKeyRegistrationOpon every block, even if they did not win sortition.