chore: select 2.05 xenon testnet start height, dead code elimination #2928
Conversation
src/core/mod.rs
Outdated
| end_height: STACKS_2_0_LAST_BLOCK_TO_PROCESS + 1, | ||
| end_height: BITCOIN_TESTNET_STACKS_2_05_BURN_HEIGHT, |
There was a problem hiding this comment.
Note that the prior value of end_height here would have made the next-costs branch broken when running on Xenon testnet: the end_height is long before the first bitcoin block height that the testnet considers
Done! |
There was a problem hiding this comment.
@kantai can we get a clean change for the new height? And do the dead code elimination in separate PR? For easier review and possible future anthropology?
|
Oh i see Jude already lgtmed.. nevermind the idea of splitting in up if it's more overhead @kantai |
src/core/mod.rs
Outdated
|
|
||
| pub const BITCOIN_TESTNET_FIRST_BLOCK_HEIGHT: u64 = 2000000; | ||
| pub const BITCOIN_TESTNET_FIRST_BLOCK_TIMESTAMP: u32 = 1622691840; | ||
| pub const BITCOIN_TESTNET_FIRST_BLOCK_HASH: &str = | ||
| "000000000000010dd0863ec3d7a0bae17c1957ae1de9cbcdae8e77aad33e3b8c"; | ||
| pub const BITCOIN_TESTNET_STACKS_2_05_BURN_HEIGHT: u64 = 2_104_076; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Seems like it, is that intentional @kantai ?
There was a problem hiding this comment.
Yep -- good catch -- updated to 2104380 -- that's the current block height (2104096) + 284, which should be about 48 hours.
This picks a 2.05 xenon/testnet start height, and does some dead code elimination
This implements #2889