-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for version 2.05.0.1.0 #2996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron Blankstein <[email protected]>
Co-authored-by: Aaron Blankstein <[email protected]>
…-blockchain into feat/hook-up-estimator
…ants, so we don't have to keep track of it in the PeerNetwork
…sting mempool queries
…not just peers we've seen before and haven't banned yet. This ensures that a node quickly resumes downloading blocks if it gets stopped and restarted during ibd
… it immediately begins to resume downloading stacks blocks (the current, erroneous behavior is for it to download 2100 bitcoin blocks unconditionally)
…e, in addition to doing so on instantiation
…ork/stacks-blockchain into feat/add-all-indexes
Co-authored-by: pavitthrap <[email protected]>
…on boot-up (this was only meant to forget about bans)
feat: Prometheus Block Fullness Metrics
Feat/add all indexes
2 metrics weren't as correct as they should be. - `stacks_node_stacks_tip_height` was moved to the relayer. in tests, this proved to be a more effective location to track the data vs what `/v2/info` was reporting - moved `stacks_node_neighbors_*` out of the pruning loop. this resulted in the metric being set more often, but the actual count of neighbors was far more accurate when compared to `/v2/neighbors` - no changes were made to the mempool tx metric, to get this more accurate will be a far heavier lift. leaving for future work - script used for testing: https://gist.github.com/wileyj/881eda423366134bc25e3fb5ec39ccbb
Update changelog
#2987 to be added next release
updating metrics for issue 2987
kantai
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just needs to merge #3036
Release 2.05.0.1.0 merge
jcnelson
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges changes from develop into master for version 2.05.0.1.0 of the stacks node.
Release Checklist