Fix mocknet events in RC #3120
Merged
Fix mocknet events in RC #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: build multi-platform docker image for Dockerfile.stretch * chore: temporary always push branch * ci: update alpine docker build and platform selection * ci: remove buildx for alpine build, configure pr docker tag * ci: create multi-platform alpine * test: temporarily always build multi-arch * fix: multi-arch alpine build needs docker buildx and qemu * ci: add new multiplatform workflow; rename or remove old workflows; remove notify jobs * ci: workflow syntax * ci: no vars allowed here * ci: reference current branch for testing * ci: test docker platforms job * ci: remove temp workflow settings Co-authored-by: CharlieC3 <[email protected]>
jcnelson
approved these changes
Apr 28, 2022
pavitthrap
approved these changes
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## develop #3120 +/- ##
============================================
- Coverage 83.81% 30.81% -53.01%
============================================
Files 260 260
Lines 200982 200950 -32
============================================
- Hits 168455 61924 -106531
- Misses 32527 139026 +106499
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the changes to the event handling in
develop, the mocknet node (node.rs), was broadcasting duplicate events. This doesn't really effect any production nodes, but would impact people using this for testing.