Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify repo README #3247

Closed
wants to merge 11 commits into from
Closed

Conversation

criadoperez
Copy link
Contributor

@criadoperez criadoperez commented Aug 10, 2022

Description

Simplified the README.md file.

  • Updated links
  • "blockstack" rebranding
  • Moved some documentation to the official Stacks docs site
  • Moved some contribution instructions to the contributions file.
  • Added references to tutorials
  • Fixes failing CircleCI icon --> Removes failing CircleCI icon

Closes #3196

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #3247 (cc1d813) into master (db3c7a2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
- Coverage   82.78%   82.77%   -0.02%     
==========================================
  Files         260      260              
  Lines      203319   203319              
==========================================
- Hits       168325   168302      -23     
- Misses      34994    35017      +23     
Impacted Files Coverage Δ
clarity/src/vm/ast/traits_resolver/mod.rs 94.44% <0.00%> (-3.97%) ⬇️
clarity/src/vm/database/sqlite.rs 78.47% <0.00%> (-1.39%) ⬇️
src/net/poll.rs 61.42% <0.00%> (-1.02%) ⬇️
src/net/inv.rs 70.57% <0.00%> (-0.77%) ⬇️
stacks-common/src/util/pipe.rs 88.40% <0.00%> (-0.54%) ⬇️
clarity/src/vm/database/key_value_wrapper.rs 96.51% <0.00%> (-0.32%) ⬇️
src/util_lib/bloom.rs 92.73% <0.00%> (-0.28%) ⬇️
clarity/src/vm/functions/mod.rs 98.10% <0.00%> (-0.24%) ⬇️
src/chainstate/stacks/index/storage.rs 78.91% <0.00%> (-0.23%) ⬇️
src/chainstate/stacks/index/marf.rs 83.84% <0.00%> (-0.20%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@criadoperez
Copy link
Contributor Author

Docs PR 1506 has merged

@criadoperez criadoperez marked this pull request as ready for review August 11, 2022 09:13
@jcnelson jcnelson self-requested a review August 15, 2022 15:30
@wileyj
Copy link
Contributor

wileyj commented Aug 15, 2022

CODE_OF_CONDUCT.md still mentions "blockstack" email address

@wileyj
Copy link
Contributor

wileyj commented Aug 15, 2022

In the readme and other markdown, links can be removed in favor of "badges" i'd argue. something along the lines here:
https://gist.github.com/tterb/982ae14a9307b80117dbf49f624ce0e8

where the license and version at least are listed.
links to things like discord/youtube etc can also be added as badges vs text links.

@criadoperez criadoperez changed the title Simply repo README Simplify repo README Aug 16, 2022
@criadoperez
Copy link
Contributor Author

In the readme and other markdown, links can be removed in favor of "badges" i'd argue. something along the lines here: https://gist.github.com/tterb/982ae14a9307b80117dbf49f624ce0e8

where the license and version at least are listed. links to things like discord/youtube etc can also be added as badges vs text links.

The scope of this PR is only for the README.md file. Other markdown files may require more changes than adding badges that will lead to further discussions, so I would rather make them on other PRs later.
I added the badges for the license, however in my opinion, if we use a double license we need to clarify more. Original text stated that

This code is released under [the GPL v3 license](https://www.gnu.org/licenses/quick-guide-gplv3.en.html), and the docs are released under [the Creative Commons license](https://creativecommons.org/).

We don't specify what type of Creative Commons license and what exactly are the docs. If we only use GPLv3 license we can leave it with the latest change I made. But, if we want to keep using both licenses we need to first state what type of Creative Commons license we are using and specify what the docs are (for example, all files in the docs folder are CC Attribution 4.0 International.

Regarding the badges of the community section, yes I can replace them.

@wileyj
Copy link
Contributor

wileyj commented Aug 16, 2022 via email

@criadoperez
Copy link
Contributor Author

I would argue that this is the correct PR to make all the changes

ok. If that's the case then I'll also review the other markdown files.

@criadoperez
Copy link
Contributor Author

CODE_OF_CONDUCT.md still mentions "blockstack" email address

Corrected. Thanks for pointing this out.

@criadoperez criadoperez marked this pull request as draft August 17, 2022 18:24
@criadoperez criadoperez marked this pull request as ready for review August 22, 2022 11:51
@wileyj wileyj closed this Dec 7, 2022
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify repo README.md
4 participants