-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify repo README #3247
Simplify repo README #3247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
==========================================
- Coverage 82.78% 82.77% -0.02%
==========================================
Files 260 260
Lines 203319 203319
==========================================
- Hits 168325 168302 -23
- Misses 34994 35017 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Docs PR 1506 has merged |
|
In the readme and other markdown, links can be removed in favor of "badges" i'd argue. something along the lines here: where the license and version at least are listed. |
The scope of this PR is only for the README.md file. Other markdown files may require more changes than adding badges that will lead to further discussions, so I would rather make them on other PRs later.
We don't specify what type of Creative Commons license and what exactly are the Regarding the badges of the community section, yes I can replace them. |
Got it. I would argue that this is the correct PR to make *all* the
changes.
There's no rush on this, and there's no impact to taking longer to merge
this -> it would actually save everyone's time to do a single PR vs many
small PR's.
…On Tue, Aug 16, 2022 at 4:30 AM Alejandro Criado-Pérez < ***@***.***> wrote:
In the readme and other markdown, links can be removed in favor of
"badges" i'd argue. something along the lines here:
https://gist.github.com/tterb/982ae14a9307b80117dbf49f624ce0e8
where the license and version at least are listed. links to things like
discord/youtube etc can also be added as badges vs text links.
The scope of this PR is only for the README.md file. Other markdown files
may require more changes than adding badges that will lead to further
discussions, so I would rather make them on other PRs later.
I added the badges for the license, however in my opinion, if we use a
double license we need to clarify more. Original text stated that
This code is released under [the GPL v3 license](https://www.gnu.org/licenses/quick-guide-gplv3.en.html), and the docs are released under [the Creative Commons license](https://creativecommons.org/).
We don't specify what type of Creative Commons license and what exactly
are the docs. If we only use GPLv3 license we can leave it with the
latest change I made. But, if we want to keep using both licenses we need
to first state what type of Creative Commons license we are using and
specify what the docs are (for example, all files in the docs folder are CC
Attribution 4.0 International
<http://creativecommons.org/licenses/by/4.0/>.
Regarding the badges of the community section, yes I can replace them.
—
Reply to this email directly, view it on GitHub
<#3247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVXIHBJ5S6KRLMDDJMGBL3VZN3VFANCNFSM56FOKZ4A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
ok. If that's the case then I'll also review the other markdown files. |
Corrected. Thanks for pointing this out. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Simplified the README.md file.
Fixes failing CircleCI icon--> Removes failing CircleCI iconCloses #3196