Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-3446: Fix block_limit_hit_integration_test #3457

Closed
wants to merge 1 commit into from

Conversation

igorsyl
Copy link
Contributor

@igorsyl igorsyl commented Dec 25, 2022

It appears the genesis block is not mined, as expected:

a86930a#diff-e782414dee532a3fcdf6a65f99f5d6455c8773d7511827ed3011082d0440976bR4801

@igorsyl igorsyl changed the base branch from master to feat/check-pox-2-params December 25, 2022 01:18
@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Merging #3457 (fae82be) into feat/check-pox-2-params (d48717f) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@                     Coverage Diff                     @@
##           feat/check-pox-2-params    #3457      +/-   ##
===========================================================
- Coverage                    30.81%   30.63%   -0.18%     
===========================================================
  Files                          298      298              
  Lines                       270835   270835              
===========================================================
- Hits                         83448    82972     -476     
- Misses                      187387   187863     +476     
Impacted Files Coverage Δ
testnet/stacks-node/src/tests/neon_integrations.rs 83.41% <100.00%> (-1.70%) ⬇️
src/chainstate/burn/db/mod.rs 37.03% <0.00%> (-3.71%) ⬇️
src/net/atlas/download.rs 75.44% <0.00%> (-3.07%) ⬇️
src/net/p2p.rs 51.29% <0.00%> (-2.26%) ⬇️
clarity/src/vm/ast/mod.rs 25.15% <0.00%> (-1.91%) ⬇️
src/net/codec.rs 40.49% <0.00%> (-1.50%) ⬇️
src/monitoring/mod.rs 60.26% <0.00%> (-1.31%) ⬇️
src/core/mempool.rs 72.92% <0.00%> (-1.11%) ⬇️
src/net/chat.rs 29.71% <0.00%> (-0.93%) ⬇️
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jcnelson added a commit that referenced this pull request Jan 2, 2023
@obycode
Copy link
Contributor

obycode commented Jan 5, 2023

I believe this is included in feat/2.1.0.0.0-rc1 and can be closed now.

@jcnelson jcnelson closed this Jan 17, 2023
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants