Chore/reorder imports #3556
Merged
Chore/reorder imports #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #3556 +/- ##
==========================================
+ Coverage 27.28% 29.36% +2.08%
==========================================
Files 305 309 +4
Lines 276796 278266 +1470
==========================================
+ Hits 75513 81702 +6189
+ Misses 201283 196564 -4719
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pavitthrap
force-pushed
the
chore/reorder-imports
branch
from
11203ce
to
34e6a54
Compare
jcnelson
approved these changes
Feb 28, 2023
|
Looks like there needs to be at least one more rebase :/ |
add more guidance to contributing.md changes to contributing.md
pavitthrap
force-pushed
the
chore/reorder-imports
branch
from
34e6a54
to
972f061
Compare
obycode
requested changes
Feb 28, 2023
docs/CONTRIBUTING.md
Outdated
|
|
||
| - When documenting panics, errors, or other conceptual sections, introduce a Markdown section with a single `#`, e.g.: | ||
|
|
||
| - ``` |
There was a problem hiding this comment.
There is an extraneous - here which messes up the formatting for the rest of the doc.
There was a problem hiding this comment.
the indent had to be fixed here!
docs/CONTRIBUTING.md
Outdated
Comment on lines
361
to
371
| #### Guidance for Slow/Non-Parallelizable Tests | ||
| PRs must include test coverage. However, if your PR includes large tests or tests which cannot run in parallel | ||
| (which is the default operation of the `cargo test` command), these tests should be decorated with `#[ignore]`. | ||
| If you add `#[ignore]` tests, you should add your branch to the filters for the `all_tests` job in our circle.yml | ||
| (or if you are working on net code or marf code, your branch should be named such that it matches the existing | ||
| filters there). | ||
|
|
||
| A test should be marked `#[ignore]` if: | ||
|
|
||
| 1. It does not _always_ pass `cargo test` in a vanilla environment (i.e., it does not need to run with `--test-threads 1`). | ||
| 2. Or, it runs for over a minute via a normal `cargo test` execution (the `cargo test` command will warn if this is not the case). |
There was a problem hiding this comment.
This sub-section should not be under the Comments section.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I used a rustfmt flag in order to do this reformatting. Here is the command:
cargo fmt --all -- --config group_imports=StdExternalCrate. To run just the check, you can runcargo fmt --all -- --check --config group_imports=StdExternalCrate.Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml