docs: fix principal -construct -destruct api reference

[hugocaillard]

Description

The api reference for principal-construct and principal-destruct was built with the wrong argument

---

Idea: An other option would be to pass function (and do it for every other make_for_simple_native calls here) to limit the risk of having the same issue in the future

PrincipalDestruct => make_for_simple_native(&PRINCPIPAL_DESTRUCT_API, &function, name),
PrincipalConstruct => make_for_simple_native(&PRINCIPAL_CONSTRUCT_API, &function, name),

I wanted to limit the footprint of my PR but let me know if I should perform this change

Applicable issues

N/A

Additional info (benefits, drawbacks, caveats

Improve the LSP.
The output type is displayed in VSCode (and other editors) on hover

Checklist

N/A

[pavitthrap]

this looks good! I think the change you proposed sounds good & would be appropriate to include in this pr

[hugocaillard]

Alright I will 👌

[obycode]

Good catch!

[codecov]

Codecov Report

Merging #3573 (9eabcc5) into develop (5923c48) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3573      +/-   ##
===========================================
- Coverage    29.86%   29.83%   -0.04%     
===========================================
  Files          298      298              
  Lines       275049   275049              
===========================================
- Hits         82152    82061      -91     
- Misses      192897   192988      +91     

Impacted Files	Coverage Δ
clarity/src/vm/docs/mod.rs	0.00% <0.00%> (ø)
testnet/stacks-node/src/tests/epoch_205.rs	21.75% <0.00%> (-76.39%)	⬇️
testnet/stacks-node/src/tests/epoch_21.rs	55.32% <0.00%> (-24.16%)	⬇️
clarity/src/vm/functions/tuples.rs	60.00% <0.00%> (-22.86%)	⬇️
clarity/src/vm/ast/traits_resolver/mod.rs	67.14% <0.00%> (-18.58%)	⬇️
...rity/src/vm/analysis/type_checker/v2_1/contexts.rs	67.87% <0.00%> (-16.75%)	⬇️
...ity/src/vm/analysis/type_checker/v2_05/contexts.rs	83.20% <0.00%> (-14.51%)	⬇️
clarity/src/vm/analysis/analysis_db.rs	75.00% <0.00%> (-14.29%)	⬇️
clarity/src/vm/callables.rs	36.19% <0.00%> (-9.62%)	⬇️
clarity/src/vm/functions/define.rs	83.47% <0.00%> (-8.27%)	⬇️
... and 78 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jcnelson]

Your doc tests are failing

[hugocaillard]

Thanks for warning me @jcnelson, I had to change PRINCIPAL_CONSTRUCT_API to a SpecialAPI

PS: when a re-requested a review from Brice, it removed you as a reviewer and now I don't have the rights to add you again

[obycode]

Great! Thanks for the updates.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.