Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vm_error to analysis failure receipts #3593

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Feb 28, 2023

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #3593 (4ddc6d6) into develop (2b70498) will increase coverage by 2.98%.
The diff coverage is 52.63%.

@@             Coverage Diff             @@
##           develop    #3593      +/-   ##
===========================================
+ Coverage    60.42%   63.40%   +2.98%     
===========================================
  Files          240      240              
  Lines       131041   131059      +18     
===========================================
+ Hits         79178    83101    +3923     
+ Misses       51863    47958    -3905     
Impacted Files Coverage Δ
src/chainstate/stacks/db/transactions.rs 58.11% <52.63%> (+0.15%) ⬆️
testnet/stacks-node/src/tests/bitcoin_regtest.rs 15.92% <0.00%> (-77.03%) ⬇️
clarity/src/vm/ast/traits_resolver/mod.rs 67.14% <0.00%> (-18.58%) ⬇️
clarity/src/vm/analysis/analysis_db.rs 77.77% <0.00%> (-14.82%) ⬇️
src/burnchains/burnchain.rs 61.36% <0.00%> (-14.69%) ⬇️
...ity/src/vm/analysis/type_checker/v2_05/contexts.rs 83.20% <0.00%> (-14.51%) ⬇️
clarity/src/vm/callables.rs 57.65% <0.00%> (-14.34%) ⬇️
clarity/src/vm/functions/define.rs 83.47% <0.00%> (-8.27%) ⬇️
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 70.58% <0.00%> (-7.70%) ⬇️
testnet/stacks-node/src/run_loop/mod.rs 91.74% <0.00%> (-7.34%) ⬇️
... and 94 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pavitthrap pavitthrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

let contracts = [
"(define-data-var bar int 0)) ;; oops",
";; `Int` instead of `int`
(define-data-var bar Int 0)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to include tests for both analysis & parse errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first test here is a parse error and the second test is an analysis error.

@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants