Feat/3596

[jcnelson]

This PR addresses #3596 by enabling using a custom existing bitcoind wallet name when mining, instead of the default one ("") created by Stacks when it boots up for the first time. This is pertinent for the listunspent and importaddress RPC calls that the node makes (h/t @MaksimalistT for bringing this up).

To use this feature, you will need to add 'wallet_name' to the '[burnchain]' section as follows:

[burnchain]
wallet_name = "name-of-your-wallet"

I have tested this with bitcoin 0.22.99.0.

[codecov]

Codecov Report

Merging #3597 (bcdbab4) into develop (cc2966b) will increase coverage by 0.94%.
The diff coverage is 4.68%.

@@             Coverage Diff             @@
##           develop    #3597      +/-   ##
===========================================
+ Coverage    30.46%   31.40%   +0.94%     
===========================================
  Files          297      298       +1     
  Lines       275498   276125     +627     
===========================================
+ Hits         83917    86717    +2800     
+ Misses      191581   189408    -2173     

Impacted Files	Coverage Δ
testnet/stacks-node/src/tests/neon_integrations.rs	86.83% <0.00%> (+3.92%)	⬆️
...-node/src/burnchains/bitcoin_regtest_controller.rs	86.43% <40.00%> (+2.24%)	⬆️
testnet/stacks-node/src/tests/epoch_21.rs	96.13% <100.00%> (-0.01%)	⬇️

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[obycode]

lgtm

[kantai]

Untagging myself as a reviewer, because this seems like a great PR for newer reviewers!

[kantai]

Meta: What is the "L1 Working Group" tag supposed to be for? Does it mean "Everything that isn't sBTC"? In which case, I'd suggest that we just delete it as tag (because "Everything that isn't sBTC" is conveyed by the lack of an sBTC tag).

[igorsyl]

Untagging myself as a reviewer, because this seems like a great PR for newer reviewers!

@jo-tm seize the opportunity!

[jcnelson]

What is the "L1 Working Group" tag supposed to be for? Does it mean "Everything that isn't sBTC"?

Right now, I've taken it to mean "things that improve the UX of the Stacks blockchain". This includes both developer UX (i.e. refactoring) as well as performance and reliability improvements. It does not include CI, devops, or docs.

[igorsyl]

What is the "L1 Working Group" tag supposed to be for? Does it mean "Everything that isn't sBTC"?

Right now, I've taken it to mean "things that improve the UX of the Stacks blockchain". This includes both developer UX (i.e. refactoring) as well as performance and reliability improvements. It does not include CI, devops, or docs.

stacks-network/stacks#468

[jio-gl]

@igorsyl sorting out my GH notifications. will review this today as a new contributor (next time in 48 hours as per the contributor guide)

[pavitthrap]

lgtm

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.