fix/ updated mempool sync protocol tests #3607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on tests for the microblock tip sync protocol, I realized that
ibd
was set to true in the call toTestPeer::step()
. Sinceibd=true
, the mempool (and microblock) sync protocol were effectively skipped over in the unit test. To avoid this problem, I am passing ibd as a parameter tostep_with_ibd
.The mempool sync tests are now fast (because the protocol now runs correctly), so I was also able to remove the timeout. I thus also removed the
#[ignore]
above the tests.