-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update atlas config #3612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @CharlieC3 @deantchi when deploying, can you keep some nodes with the old setting, just in case this puts too much load on the p2p threads of the new nodes?
Codecov Report
@@ Coverage Diff @@
## develop #3612 +/- ##
===========================================
+ Coverage 83.80% 85.49% +1.68%
===========================================
Files 297 298 +1
Lines 276103 276674 +571
===========================================
+ Hits 231397 236550 +5153
+ Misses 44706 40124 -4582
... and 55 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
From blockchain meeting: test this live on mainnet for a week |
Now that we have a configurable version of this PR (#3618), should we close this one? |
PR #3618 is still using the old default values. If the testing by @CharlieC3 and @zone117x show these values to be an improvement, we can merge this PR to update the defaults |
Blockchain meeting: testing halfway complete, need to see how these values affect attachment performance |
In this PR, we're bumping
max_uninstantiated_attachments
to 50k anduninstantiated_attachments_expire_after
to 1 day.