Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistent markdown formatting #3615

Merged
merged 1 commit into from
Mar 17, 2023
Merged

docs: consistent markdown formatting #3615

merged 1 commit into from
Mar 17, 2023

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 14, 2023

The main goal of this commit is to resolve the issues where a newline was intended, but because Markdown formatting uses two newlines to separate paragraphs, these lines were being merged into one. This was especially apparent in the lists of possible error codes, which I've now reformatted to use bulleted lists.

For example, the following string in the source:

"...
`(err u1)` -- `sender` does not have enough balance to transfer
`(err u2)` -- `sender` and `recipient` are the same principal
`(err u3)` -- amount to send is non-positive
"

Resulted in the this formatting on the docs site:
image

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3615 (c825e1e) into develop (bcdbab4) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3615      +/-   ##
===========================================
- Coverage    31.40%   31.08%   -0.32%     
===========================================
  Files          298      298              
  Lines       276125   276125              
===========================================
- Hits         86717    85844     -873     
- Misses      189408   190281     +873     
Impacted Files Coverage Δ
clarity/src/vm/docs/mod.rs 0.00% <ø> (ø)

... and 41 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

clarity/src/vm/docs/mod.rs Outdated Show resolved Hide resolved
clarity/src/vm/docs/mod.rs Outdated Show resolved Hide resolved
The main goal of this commit is to resolve the issues where a newline
was intended, but because Markdown formatting uses two newlines to
separate paragraphs, these lines were being merged. This was especially
apparent in the lists of possible error codes, which I've now
reformatted to use bulleted lists.
@igorsyl
Copy link
Contributor

igorsyl commented Mar 17, 2023

Good first issue to review @soju-drinker. You should be getting contributor access later today! cc @wileyj

@jcnelson jcnelson merged commit 8432df3 into develop Mar 17, 2023
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants