Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge: PR #3598 burnchain naming to develop #3626

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

kantai
Copy link
Member

@kantai kantai commented Mar 21, 2023

Description

This PR merges changes from the contributor in #3598

r0zar and others added 2 commits March 8, 2023 06:20
To normalize naming conventions
…eanup

🚚 Rename burn_chain_tip to burnchain_tip
@obycode
Copy link
Contributor

obycode commented Mar 21, 2023

Maybe easier to just cherry-pick the one commit?

@kantai
Copy link
Member Author

kantai commented Mar 21, 2023

Maybe easier to just cherry-pick the one commit?

I think once the master -> develop PR merges, this PR will reduce in size substantially

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #3626 (3c6d177) into develop (e0de91f) will increase coverage by 2.53%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop    #3626      +/-   ##
===========================================
+ Coverage    26.15%   28.68%   +2.53%     
===========================================
  Files          297      298       +1     
  Lines       276040   276611     +571     
===========================================
+ Hits         72185    79345    +7160     
+ Misses      203855   197266    -6589     
Impacted Files Coverage Δ
src/burnchains/burnchain.rs 70.22% <75.00%> (+3.98%) ⬆️

... and 105 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kantai kantai merged commit 8cb8340 into develop Mar 22, 2023
@kantai kantai deleted the pointblankdev-maint/burnchain-naming-cleanup branch March 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants