Feat: Add peer-pub-key command to stacks-inspect
#3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3633 +/- ##
============================================
- Coverage 84.93% 30.09% -54.84%
============================================
Files 298 298
Lines 276611 276633 +22
============================================
- Hits 234941 83260 -151681
- Misses 41670 193373 +151703
... and 263 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pavitthrap
approved these changes
Mar 24, 2023
| @@ -3808,25 +3807,6 @@ impl PeerThread { | |||
| } | |||
|
|
|||
| impl StacksNode { | |||
| /// Create a StacksPrivateKey from a given seed buffer | |||
| pub fn make_node_private_key_from_seed(seed: &[u8]) -> StacksPrivateKey { | |||
There was a problem hiding this comment.
there's a build failure related to this function - it's used in more places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifying
bootstrap_nodeentries in a stacks-node config file requires the peer's public key. Figuring out a peer's public key from itslocal_peer_seedisn't always trivial (you can get it from the logs during node bootup, but you don't necessarily want to have to deploy a node to figure out what its public key will be).But, computing the public key from a peer seed value is pretty easy from the library, so I added a
peer-pub-keycommand tostacks-inspectwhich can help in this case.