Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Signature order-independence fix for multisig tx #3710

Merged
merged 69 commits into from
May 16, 2024
Merged

Feat: Signature order-independence fix for multisig tx #3710

merged 69 commits into from
May 16, 2024

Commits on Nov 27, 2023

  1. feat: order independent multisig hash modes supported, gating logic a… 

    …dded, deserialize with epoch trait implemented
    @fess-v
    fess-v committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    12fe0ae View commit details
    Browse the repository at this point in the history

  2. fix: failing autotests fixes

    @fess-v
    fess-v committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2a001ae View commit details
    Browse the repository at this point in the history

  3. fix: nakamoto autotest fix

    @fess-v
    fess-v committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    92bbea9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. fix: autotests added for one multisig address and both multisig trans… 

    …action types
    @fess-v
    fess-v committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bd6df03 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge commit 2c1c777b9 into multisig-order-independence

    @jbencin
    jbencin committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7da8498 View commit details
    Browse the repository at this point in the history

  2. Merge commit e716bb61b into multisig-order-independence

    @jbencin
    jbencin committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1076881 View commit details
    Browse the repository at this point in the history

  3. Merge commit e71444a into multisig-order-independence

    @jbencin
    jbencin committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fc81647 View commit details
    Browse the repository at this point in the history

  4. Merge commit 3e21883 into multisig-order-independence

    @jbencin
    jbencin committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5afef38 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge commit 15e76e5 into multisig-order-independence

    @jbencin
    jbencin committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d11e073 View commit details
    Browse the repository at this point in the history

  2. Merge commit be489b4 into multisig-order-independence

    @jbencin
    jbencin committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dc247f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge commit 7c7a527 into multisig-order-independence

    @jbencin
    jbencin committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    122c9f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. fix: Unit/integration tests (except `test_epoch_switch_pox_3_contract… 

    …_instantiation`)
    @jbencin
    jbencin committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    be87938 View commit details
    Browse the repository at this point in the history

  2. Merge commit f8c676073 into multisig-order-independence

    @jbencin
    jbencin committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3c9b3c4 View commit details
    Browse the repository at this point in the history

  3. fix: Unit/integration tests (except `test_epoch_switch_pox_3_contract… 

    …_instantiation`)
    @jbencin
    jbencin committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    23b44eb View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge commit 577b118 into multisig-order-independence

    @jbencin
    jbencin committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1cb66b7 View commit details
    Browse the repository at this point in the history

  2. Merge commit cab1a11b5 into multisig-order-independence

    @jbencin
    jbencin committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    957ecd9 View commit details
    Browse the repository at this point in the history

  3. Merge branch stacks/next into multisig-order-independence

    @jbencin
    jbencin committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d615a8b View commit details
    Browse the repository at this point in the history

  4. fix: stackslib/src/chainstate/coordinator/tests.rs passes

    @jbencin
    jbencin committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8cdd2dd View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge pull request #1 from jbencin/multisig-order-independence 

    Multisig order independence
    @fess-v
    fess-v authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    857be7f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into draft/multisig-order-independence

    @jbencin
    jbencin authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    80a3565 View commit details
    Browse the repository at this point in the history

  3. chore: Address PR comments and fix tests

    @jbencin
    jbencin committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    78b05a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge pull request #2 from jbencin/multisig-order-independence 

    chore: Address PR comments and fix tests
    @fess-v
    fess-v authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    988f667 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Merge branch 'next' into draft/multisig-order-independence

    @jcnelson
    jcnelson authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c17045d View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. chore: Remove DeserializeWithEpoch trait

    @jbencin
    jbencin committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7b4794d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from jbencin/multisig-order-independence 

    chore: Remove `DeserializeWithEpoch` trait
    @fess-v
    fess-v authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0deff44 View commit details
    Browse the repository at this point in the history

  3. fix: remove logic for epoch gating

    @fess-v
    fess-v committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    758c58a View commit details
    Browse the repository at this point in the history

  4. fix: failing autotests fix and transaction.rs test code refactoring

    @fess-v
    fess-v committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    bb66bae View commit details
    Browse the repository at this point in the history

  5. fix: format

    @fess-v
    fess-v committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    aaa37f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. fix: warning

    @fess-v
    fess-v committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a995f21 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Update stackslib/src/net/api/tests/gettenure.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    0fd0321 View commit details
    Browse the repository at this point in the history

  2. Update stackslib/src/net/api/tests/getblock.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1cb0dcb View commit details
    Browse the repository at this point in the history

  3. Update stackslib/src/net/api/tests/getblock_v3.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f7dbfed View commit details
    Browse the repository at this point in the history

  4. Update stackslib/src/net/codec.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1549a9a View commit details
    Browse the repository at this point in the history

  5. Update stackslib/src/net/api/posttransaction.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6c4c50d View commit details
    Browse the repository at this point in the history

  6. Update stackslib/src/net/api/postblock.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    551761c View commit details
    Browse the repository at this point in the history

  7. Update stackslib/src/net/api/getblock.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f84cc68 View commit details
    Browse the repository at this point in the history

  8. Update stackslib/src/net/api/gettenure.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a057bc2 View commit details
    Browse the repository at this point in the history

  9. Update stackslib/src/chainstate/nakamoto/staging_blocks.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d644759 View commit details
    Browse the repository at this point in the history

  10. Update stacks-common/src/codec/mod.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    15cd521 View commit details
    Browse the repository at this point in the history

  11. Update stackslib/src/blockstack_cli.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    341e17a View commit details
    Browse the repository at this point in the history

  12. fix: revert messages.rs file

    @fess-v
    fess-v committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2167f2f View commit details
    Browse the repository at this point in the history

  13. fix: redundant import removed

    @fess-v
    fess-v committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ac057ca View commit details
    Browse the repository at this point in the history

  14. Update stackslib/src/net/api/getblock_v3.rs 

    Co-authored-by: Jeff Bencin <[email protected]>
    @fess-v @jbencin
    fess-v and jbencin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c4b0952 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. feat: Allow for more than min number of signers in `OrderIndependentM… 

    …ultisigSpendingCondition`
    @jbencin
    jbencin committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    1358151 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from jbencin/multisig-order-independence 

    feat: Allow for more than min number of signers in `OrderIndependentMultisigCondition`
    @fess-v
    fess-v authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2f06d95 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. fix: redundant code reverted, quiet parameter removed

    @fess-v
    fess-v committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    72507cc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/draft/multisig-order-independenc… 

    …e' into draft/multisig-order-independence
    @fess-v
    fess-v committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a91581d View commit details
    Browse the repository at this point in the history

  3. fix: supported in epoch added

    @fess-v
    fess-v committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8df5b31 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. fix: TransactionAuth is_supported_in_epoch docstring added, autotest … 

    …added
    @fess-v
    fess-v committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9dfa3c4 View commit details
    Browse the repository at this point in the history

  2. test: Add cases in auth.rs for num_sigs > required_sigs

    @jbencin
    jbencin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5d25b5c View commit details
    Browse the repository at this point in the history

  3. fix: Tests broken by 13581510c now work. Also, added test to confir… 

    …m extra signers work
    @jbencin
    jbencin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d981cec View commit details
    Browse the repository at this point in the history

  4. Merge pull request #5 from jbencin/multisig-order-independence 

    Add/fix tests for when num_signers > required_signers
    @fess-v
    fess-v authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fa95032 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. chore: Address PR comments from Jude

    @jbencin
    jbencin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6bd3a61 View commit details
    Browse the repository at this point in the history

  2. chore: Address PR comments from Jude

    @jbencin
    jbencin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    be71ee8 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge pull request #6 from jbencin/multisig-order-independence 

    Multisig order independence
    @fess-v
    fess-v authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cfdc8f1 View commit details
    Browse the repository at this point in the history

  2. fix: Unit tests pass

    @jbencin
    jbencin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f910e6d View commit details
    Browse the repository at this point in the history

  3. refactor: Pass Options to verify_block_epoch_validation()

    @jbencin
    jbencin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b25eef8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #7 from jbencin/multisig-order-independence 

    Multisig order independence
    @fess-v
    fess-v authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    452a400 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. fix: rustdocs added for test functions

    @fess-v
    fess-v committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7a49afa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/stacks-network/stacks-bl… 

    …ockchain into draft/multisig-order-independence
    @fess-v
    fess-v committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3dd4ccb View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge branch 'develop' into draft/multisig-order-independence

    @jcnelson
    jcnelson authored May 3, 2024
    Configuration menu
    Copy the full SHA
    679aeac View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. fix: autotest restored, epoch gating logic removed from `try_mine_tx_… 

    …with_len`
    @fess-v
    fess-v committed May 5, 2024
    Configuration menu
    Copy the full SHA
    4a0a966 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/draft/multisig-order-independenc… 

    …e' into draft/multisig-order-independence
    @fess-v
    fess-v committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3c7be76 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into draft/multisig-order-independence

    @fess-v
    fess-v authored May 5, 2024
    Configuration menu
    Copy the full SHA
    61ac533 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'develop' into draft/multisig-order-independence

    @jcnelson
    jcnelson authored May 10, 2024
    Configuration menu
    Copy the full SHA
    6e2b54b View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Merge branch 'develop' into draft/multisig-order-independence

    @fess-v
    fess-v authored May 11, 2024
    Configuration menu
    Copy the full SHA
    d7865cf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Update stackslib/src/chainstate/stacks/transaction.rs 

    Co-authored-by: Brice Dobry <[email protected]>
    @fess-v @obycode
    fess-v and obycode authored May 16, 2024
    Configuration menu
    Copy the full SHA
    2e67fa9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into draft/multisig-order-independence

    @jbencin
    jbencin authored May 16, 2024
    Configuration menu
    Copy the full SHA
    6766e65 View commit details
    Browse the repository at this point in the history

  3. fix: validate_transaction_static_epoch function added

    @fess-v
    fess-v committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9addd7e View commit details
    Browse the repository at this point in the history