-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: merge master into develop #3730
Conversation
Update README testnet command
Docs: Update CONTRIBUTING.md, add PR review guidelines
Co-authored-by: Aaron Blankstein <[email protected]>
No AI code for the foreseeable future.
Codecov Report
@@ Coverage Diff @@
## develop #3730 +/- ##
===========================================
+ Coverage 85.08% 85.62% +0.53%
===========================================
Files 298 302 +4
Lines 276674 286545 +9871
===========================================
+ Hits 235397 245342 +9945
+ Misses 41277 41203 -74
... and 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it needs some merge fixes / artifact fixes -- the test build is currently failing on the branch.
In reviewing this, I noticed that there is nothing added to the changelog about the atlas changes. @jbencin please add something in a separate PR after this one is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I added two comments about missing changleog entries that I noticed while reviewing, that can be addressed in separate PRs.
outside of reading the commit, no - but it does look eerily similar to the changes in #3694 . |
remove additional `#` Co-authored-by: Brice Dobry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This merges the updates (up to latest epoch 2.4 release) in
master
back todevelop
.