Chore: replace u32::max_value() with u32::MAX

[pavitthrap]

Description

This is a chore PR to merge PR #3735.

[codecov]

Codecov Report

Merging #3739 (4c0182a) into develop (56493ac) will increase coverage by 0.54%.
The diff coverage is 80.68%.

@@             Coverage Diff             @@
##           develop    #3739      +/-   ##
===========================================
+ Coverage    85.08%   85.63%   +0.54%     
===========================================
  Files          298      302       +4     
  Lines       276674   286537    +9863     
===========================================
+ Hits        235397   245362    +9965     
+ Misses       41277    41175     -102     

Impacted Files	Coverage Δ
...larity/src/vm/analysis/arithmetic_checker/tests.rs	98.39% <ø> (ø)
clarity/src/vm/analysis/errors.rs	72.09% <0.00%> (-0.34%)	⬇️
clarity/src/vm/analysis/read_only_checker/tests.rs	100.00% <ø> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs	95.17% <ø> (ø)
.../src/vm/analysis/type_checker/v2_1/tests/assets.rs	100.00% <ø> (ø)
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs	96.39% <ø> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs	99.08% <ø> (ø)
clarity/src/vm/tests/defines.rs	97.84% <ø> (ø)
clarity/src/vm/tests/sequences.rs	99.60% <ø> (ø)
clarity/src/vm/tests/simple_apply_eval.rs	99.56% <ø> (ø)
... and 73 more

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[netrome]

I'm curious, why do we need an additional PR to merge this one? I.e. why couldn't #3739 be merged directly to develop?

[obycode]

I'm curious, why do we need an additional PR to merge this one? I.e. why couldn't #3739 be merged directly to develop?

It's because the two checks that build and publish docker images fail when PRs come from forks, since the keys are not available to the CI. We discussed this before and I think the consensus is that these checks should not be required, or should only run in certain scenarios, but until that is resolved, we have to do this to workaround it.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.