Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode the dockerhub org #3741

Merged
merged 2 commits into from
Jun 7, 2023
Merged

hardcode the dockerhub org #3741

merged 2 commits into from
Jun 7, 2023

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Jun 6, 2023

Resolves an issue with the dockerhub repo being named differently than the github org https://github.com/stacks-network/stacks-blockchain/actions/runs/5193175067

reverts the image name from the testing repo of ${{ github.repository }} (i.e. stacks-network/stacks-blockchain) -> blockstack/${{ github.event.repository.name }} (blockstack/stacks-blockchain)

https://hub.docker.com/u/blockstack

@wileyj wileyj requested review from obycode and pavitthrap June 6, 2023 21:14
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3741 (6be1202) into master (8a7a371) will decrease coverage by 58.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3741       +/-   ##
===========================================
- Coverage   58.31%    0.17%   -58.14%     
===========================================
  Files           1      302      +301     
  Lines         571   285382   +284811     
===========================================
+ Hits          333      512      +179     
- Misses        238   284870   +284632     

see 301 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wileyj
Copy link
Contributor Author

wileyj commented Jun 6, 2023

Added second commit to address incorrect naming in the base bitcoin-test image: https://github.com/stacks-network/stacks-blockchain/actions/runs/5193424766/jobs/9364613730?pr=3741

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj wileyj requested a review from igorsyl June 7, 2023 17:23
Copy link
Contributor

@igorsyl igorsyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@wileyj wileyj merged commit 1da60ad into master Jun 7, 2023
fess-v pushed a commit to fess-v/stacks-blockchain that referenced this pull request Sep 10, 2023
* hardcode the dockerhub org

* rename base image to stacks-blockchain from stacks-node
fess-v pushed a commit to fess-v/stacks-blockchain that referenced this pull request Sep 10, 2023
* hardcode the dockerhub org

* rename base image to stacks-blockchain from stacks-node
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants