Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test flakiness in CI #3743

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Reduce test flakiness in CI #3743

merged 4 commits into from
Jun 20, 2023

Conversation

pavitthrap
Copy link
Contributor

Description

I'm attempting to lower the flakiness by adding some sleep statements in the following three tests:

  • test_problematic_microblocks_are_not_relayed_or_stored
  • epoch_23::trait_invocation_behavior
  • epoch_22: pox_2_unlock_all

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #3743 (b57741e) into develop (7a0e572) will decrease coverage by 0.23%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##           develop    #3743      +/-   ##
===========================================
- Coverage    85.79%   85.56%   -0.23%     
===========================================
  Files          302      302              
  Lines       286529   286544      +15     
===========================================
- Hits        245830   245187     -643     
- Misses       40699    41357     +658     
Impacted Files Coverage Δ
testnet/stacks-node/src/tests/neon_integrations.rs 82.91% <83.33%> (-0.47%) ⬇️
testnet/stacks-node/src/tests/epoch_22.rs 96.17% <100.00%> (+<0.01%) ⬆️
testnet/stacks-node/src/tests/epoch_23.rs 99.63% <100.00%> (+<0.01%) ⬆️

... and 45 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. 👍

@wileyj wileyj merged commit 538941f into develop Jun 20, 2023
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants